bug: restore audio on live streams and demo playback - #584
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Live streams, demo playback and highlights have been silent over WebRTC since the cameras PR (#548). Clips were unaffected because they are plain mp4s, and the streamer's audio capture was fine all along.
#548 added an
audio?: booleanprop toWhepPlayer, read asprops.audio !== false. Vue casts an absent boolean prop tofalse, notundefined, so every host that does not pass it (bothStreamCanvasmounts) never offered an audio transceiver and MediaMTX never sent the track.audionow defaults totrueexplicitly. The camera grid is unaffected, it passes:audioitself.Also fixes a mute desync from the same PR.
mutedgets the same absent-to-falsecast, so the player tries to unmute itself without a user gesture. When the browser blocks that,tryPlayre-muted the element but leftisMutedfalse, so the "tap to unmute" pill never showed. They now stay in sync.Tests: 111.